Fix - Esri Attribution not removed when VectorBasemapLayer is removed #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BrunoCaimar thank you for the PR. I tested this using my demo case from the original issue: https://jsbin.com/liriren/4/edit?html,output
And it seems like it's still the same thing using your PR: Can you please check this case? Thanks! |
|
@gavinr-maps We will need to call removeEsriAttribution from esri-leaflet to fix that. Unfortunately, this method is not exported there: EsriUtils export. We will need to do that before fixing this here. I'll send a PR there, adding the method to the export. Do you need an issue there to reference this? |
this method removes the "Powered by Esri" attribution
|
|
|
Hi @BrunoCaimar, thanks a lot for working on this. Is there more work to do on this PR or is it ready for review? |
|
It is ready to review. |
gavinr-maps
requested changes
Dec 8, 2023
+ avoid error when using previous versions of esri-leaflet that do not contain the function
gavinr
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #136